Re: Re: Patch for 2.6.10 kernel

[Donovan Baarda <abo at minkirri dot apana dot org dot au>]

On Thu, 2005-01-13 at 10:05 +0100, Flavio Stanchina wrote:
> Julien Valroff wrote:
> > I am pretty sure you are already aware that there is a problem using ATI's 
> > drivers with 2.6.10 kernel, [...]
>
> I am aware of the problem. In fact, I'm actually using 2.6.10 myself, 
> but I devised a slightly different solution: I just ripped off the 
> built-in AGP support code, which is where this problem lies (and so did 
> several others before). I'm perfectly happy with the kernel's AGP driver 
> and I believe having a slightly enhanced copy of an older version of the 
> AGP driver within the fglrx module is not a good idea: it will be a 
> source of compatibility problems as long as the kernel evolves, that is, 
> hopefully, forever.

Is this the "same effect" as running with;

        Option  "UseInternalAGPGART"    "no" 

in your XF86Config-4? Is there still known cases where the built-in AGP
support code is still required to make it work?

I already apply a small patch when building my module debs so they build
against kernel-headers only (by adding missing drm headers from a kernel
source). I suspect "stripping out" the AGP stuff like this would also
removed the ugly use of kernel-source drm headers.

If there is very few people that really need the built in AGP, I'd
prefer a patch that strips it out than hacks in the drm headers. If you
could post a patch...

[...]
> To sum it up, I *don't* want to apply this patch to the code I'm 
> distributing: I'd rather leave users with a module that doesn't build 
> than with one that builds but causes crashes or misbehaves somehow, so 
> I'll wait for an official fix from ATI.

Probably wise... though I dunno if ATI will produce as clean a fix as
you have suggested... if the current make.sh is anything to go by...
sometimes it is better to lead than follow :-)

BTW, my kernel module debs for standard Debian kernels is available at;

deb http://minkirri.apana.org.au/pub/debian-local/ ./

Also, a wiki page describing how these debs are built is available at;

http://www.melb.apana.org.au/Melb/MelbWiki/ATIRadeon9600

Feel free to use :-)

-- 
Donovan Baarda <abo at minkirri dot apana dot org dot au>
http://minkirri.apana.org.au/~abo/